* refactor exchange; use `distance` instead of `simple_distance`
* fix: put distance in a variable
* refactor: use Math.floor over parseInt
* rename variable to avoid name conflict
* Align firebow with other fire weapons
Detailed changes:
- Now possible to dismantle firebow
- Firebow essenceoffire cost reduced to 1 (was 2)
- Firebow crafting cost reduced to 20k (was 40k)
- Firebow can be looted from the phoenix
- Firebow can be obtained from weaponbox
Discord suggestion thread: https://discord.com/channels/238332476743745536/1228326390294646834/1228326390294646834
* Fix firebow grade
* remove the temp monster drop limitation
* clarity... enhance!
* move shouldItemDrop back into drop_something for scoped variables
* docstring enhancement
* remove the artifact comparison operator and item[0]
---------
Co-authored-by: Mark Tur <mark.tur@warnermedia.com>
* add timeout to `use`
* refactor: use Math.min directly
* fix: remove eval
It doesn't look good in the UI, we can assume that the current timeout is already shown in the UI
If a player was not on the server when the giveaway ended, or their inventory was full, then the server would push `{ name: undefined }` into the list of players that could win the giveaway. This would send the item into the abyss, as it would error while the server would try to mail the item, preventing it from being recovered.
This fixes a bug with giveaways. Giveaways would previously list all of the participants of a giveaway in the mail, but at some point a breaking change occurred, and instead it lists [object Object] multiple times.
Prior to this change, Piercing Shot (A ranger skill) that gives 500 armor piercing would only grant this pierce if the player had no pierce themselves. If the player had pierce, the pierce from the skill would then be overwritten by the player's pierce. This change fixes it by adding the player's pierce (or miss chance!) to the skills stats.
This PR aims to fix a bug where if a user attempts to shiny an item using the upgrade station and an offering, if it succeeds, the server does not send a response. This appears to occur because the server sets a "announce" flag to be false when the upgrade is a shiny attempt, and this prevents the success response from being sent to the client.
(Original PR: #105)
This PR changes Fire Resistance to not only affect the chance of getting burned, but also having higher Fire Resistance reduces the duration and intensity of the burn debuff. For instance, if the player had N fire resistance, they would have a N% chance to simply not get burned, but also, the duration would be reduced by N%, and the intensity would be reduced by N%.
Crowns3bc