Matsubaa/adventureland
1
0
Fork 0
mirror of https://github.com/gooba42/adventureland.git synced 2026-10-14 18:39:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove the temp monster drop limitation (#145)

Browse Source 
* remove the temp monster drop limitation

* clarity... enhance!

* move shouldItemDrop back into drop_something for scoped variables

* docstring enhancement

* remove the artifact comparison operator and item[0]

---------

Co-authored-by: Mark Tur <mark.tur@warnermedia.com>
This commit is contained in:
Mark
2024-08-13 17:06:01 +02:00
committed by GitHub
co-authored by Mark Tur
parent c584e56f09
commit 473917b0b3
1 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
node/server.js
+27 -10
View File
@@ -2017,14 +2017,34 @@ function drop_something(player, monster, share) {
}
});
}
/**
* Determines whether an item should drop for a player based
* on the drop rate and luck modifiers.
* @param {Array} item - An array representing the item to be
* dropped, where item[0] is the drop rate.
* @returns {boolean} - true if the item should drop,
* false if the item should NOT drop.
* Change Note:
* - [7/17/24] - ATLUS - 'temp' monsters should also roll for drops
*/
const shouldItemDrop = (item) => {
// 1) calculate the drop rate
// 2) calculate & use roll modifier on a random roll (0 <= N < 1)
// 3) item drops if the calculated falls below the drop rate threshold
let dropRate = item[0];
let rollModifier = share / player.luckm / monster.level / monster_mult;
let playerRoll = Math.random() / rollModifier;
return playerRoll < dropRate;
};
// if(player.level<50 && monster.type=="goo" && mode.low49_200xgoo) monster_mult=200;
if (D.drops.monsters[monster.type] && player.tskin != "konami") {
D.drops.monsters[monster.type].forEach(function (item) {
if (
((!monster.temp || item[0] > 0.00001) &&
Math.random() / share / player.luckm / monster.level / monster_mult < item[0]) ||
mode.drop_all
) {
let itemShouldDrop = shouldItemDrop(item);
if (itemShouldDrop || mode.drop_all) {
// /hp_mult - removed [13/07/18]
drop_item_logic(drop, item, is_in_pvp(player, 1));
}
@@ -2032,11 +2052,8 @@ function drop_something(player, monster, share) {
}
if (monster.drops) {
monster.drops.forEach(function (item) {
if (
((!monster.temp || item[0] > 0.00001) &&
Math.random() / share / player.luckm / monster.level / monster_mult < item[0]) ||
mode.drop_all
) {
let itemShouldDrop = shouldItemDrop(item);
if (itemShouldDrop || mode.drop_all) {
// /hp_mult - removed [13/07/18]
drop_item_logic(drop, item, is_in_pvp(player, 1));
}